[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH 05/13] Drive the debug editor

From: Jonathan Nieder <jrnieder_at_gmail.com>
Date: Wed, 7 Jul 2010 14:53:21 -0500

Ramkumar Ramachandra wrote:
> Jonathan Nieder writes:
>> Ramkumar Ramachandra wrote:

>>> - de->apply_textdelta = apply_textdelta;
>>> + /* de->apply_textdelta = apply_textdelta; */
[...]
> Without this, the program segfaults because the necessary setup for
> applying a text delta hasn't been set up. Perhaps I should explain
> this in my commit message?

Is the default apply_textdelta not a no-op? What work does it have to
do, and can the skeleton editor be convinced to do the same in patch 4?

>>> +{
>>> + /* Extract editor and editor_baton from the replay_baton and
>>> + set them so that the editor callbacks can use them */
>>
>> This comment just paraphrases the code. What in particular requires
>> explanation here?
>
> This concept took me some time to wrap my head around: I had to stuff
> the replay_baton with the editor/ editor_baton so that I could set
> them for use in the callback functions.

Ah, okay. Then I suppose it belongs in the commit message.

Alternatively: why does the tree editor have to persist between calls
replaying the various revisions? That information could help the
reader understand what is going on.
Received on 2010-07-07 21:54:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.