Stefan Sperling wrote:
> Ramkumar Ramachandra wrote:
> > I have recently developed a new svn_editor_t editor for Subversion
> > that uses the replay API to generate a dumpfile v3 over the network
> I see value in adding this feature to Subversion.
> Generating a dump file from a remote repository certainly has a
> couple of interesting use cases.
It's very nice to see someone coming and enthusiastically offering us
some new working code.
I agree it looks like it's useful as well as interesting, and it seems
to me that this would be a reasonable extension to the set of software
that is "the Subversion software" - it implements a sensible combination
of existing concepts.
> I'd prefer adding this as a new command, such as "svnrdump" ("remote dump").
> Obviously, we'll need a patch in proper shape. That means it's against
> our trunk (it doesn't matter whether you produce diff output with git or
> with svn), and that the coding style (indentation etc.) matches the
> conventions used in svn, and that the tool behaves like the other CLI
> tools we have regarding option parsing, help output, etc.
> Also, please don't send one patch per file, but send the entire thing
> in one patch.
I'll just point out that his patches yesterday were each one logical
change made across several files, in case you missed that.
> A set of unit tests for the new command within our regression test
> suite would be nice (similar to svnlook_tests.py and svnsync_tests.py).
> These could be submitted in a separate patch.
> Unless you hear objections during the next few days, I'd suggest you
> start working on a patch aimed at our trunk (instead of at git).
> I'm not sure how GSOC handles cases like this though. Please make sure
> your mentor is aware of patches you send here, and is willing to work
> with you even if you direct them at Subversion rather than git.
> I don't expect a problem (being a gsoc mentor myself this year and last
> year I have had good experience with the program and the people who
> run it), but you should certainly make sure Google is still willing to
> support you even if you technically switch projects while summer of code
> is running.
Received on 2010-07-07 18:35:47 CEST