[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] disable mod-activation by default

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 6 Jul 2010 15:39:55 +0200

I find myself frowning upon the fact that Subversion's build system
is trying to modify files in the /etc directory by default.

It is nice when it works and users expect it, but it is not so nice
when it does not work, or when it works but the user isn't expecting it.
So I think we should have users explicitly ask for files in /etc
to be modified.

Since most people use binary packages these days and rarely build from
source, this change will not affect many of our users. Most packagers
already pass --disable-mod-activation and provide OS-specific means of
configuring Apache to work with Subversion.

Also, this does not break existing setups which already pass
--disable-mod-activation.

Any objections?

Stefan

[[[
* configure.ac: Change the default of --disable-mod-activation to "yes".
   IOW, our build system now requires the --enable-mod-activation option
   in order to tweak the system's Apache httpd configuration to load
   the mod_dav_svn module.
]]]

Index: configure.ac
===================================================================
--- configure.ac (revision 960864)
+++ configure.ac (working copy)
@@ -942,16 +942,16 @@ AS_HELP_STRING([--with-editor=PATH],
 
 SVN_LIB_Z
 
-MOD_ACTIVATION="-a"
+MOD_ACTIVATION=""
 AC_ARG_ENABLE(mod-activation,
-AS_HELP_STRING([--disable-mod-activation],
- [Do not enable mod_dav_svn in httpd.conf]),
+AS_HELP_STRING([--enable-mod-activation],
+ [Enable mod_dav_svn in httpd.conf]),
 [
- if test "$enableval" = "no" ; then
- MOD_ACTIVATION=""
+ if test "$enableval" = "yes" ; then
+ MOD_ACTIVATION="-a"
+ AC_MSG_NOTICE([Enabling apache module activation])
+ else
       AC_MSG_NOTICE([Disabling apache module activation])
- else
- AC_MSG_NOTICE([Enabling apache module activation])
     fi
 ])
 AC_SUBST(MOD_ACTIVATION)
Received on 2010-07-06 15:40:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.