On Fri, Jul 02, 2010 at 11:42:58AM +0100, Julian Foad wrote:
> Any objection to this step? The only down side I can think of is the
> slight inconvenience for us developers of having to quote the path on
> the command line when debugging the tests, and that's not something that
> should put us off.
I tend to find spaces in filenames I work with on the command line quite
annoying. So I'd prefer explicit unit tests which check for whitespace
within local paths and within URLs, much like what you listed below.
Onno, do you have time and some rudimentary python skills (or time
to pick those up)? If so, it would be great if you could contribute
a couple of such tests (you could start slowly with just one test,
get it reviewed and committed, and then do more if you want to).
That would help us a lot in catching such bugs in the future.
> Then we can work on extending the principle in one or more different
> ways, which, I'm sure, will detect a bunch of bugs:
> * space in some of the within-WC paths;
> * other ASCII pathnames that require URI-escaping, or in any other way
> have the potential to be mis-handled by Subversion;
> * non-ASCII characters (but the ability to do this would depend on
> what locales the test platform supports, and so would require
> configuration magic to enable it);
> * similar things for repository-side paths.
> - Julian
Received on 2010-07-02 13:46:46 CEST