Re: svn commit: r959270 - in /subversion/trunk/subversion: bindings/javahl/native/CreateJ.cpp include/private/svn_wc_private.h libsvn_client/info.c libsvn_wc/node.c libsvn_wc/status.c libsvn_wc/wc.h

On Wed, Jun 30, 2010 at 07:25, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Wed Jun 30 11:25:33 2010
> New Revision: 959270
>
> URL: http://svn.apache.org/viewvc?rev=959270&view=rev
> Log:
> Remove another use of entries, by creating an node function that only
> calculates the entry-like schedule and copied flag of a node.
>
> * subversion/bindings/javahl/native/CreateJ.cpp
>  (CreateJ::Status): Update caller.
>
> * subversion/include/private/svn_wc_private.h
>  (svn_wc__node_get_info_bits): Remove schedule argument.
>  (svn_wc__node_get_schedule): New function.
>
> * subversion/libsvn_client/info.c
>  (build_info_for_entry): Retrieve schedule using svn_wc__node_get_schedule.
>
> * subversion/libsvn_wc/node.c
>  (svn_wc__internal_node_get_schedule): New function.
>  (svn_wc__node_get_schedule): New function.

Rather than writing a long function that *might* get the schedule
correct, I think it is best to simply fetch the entry and return
entry->schedule and entry->copied. There is a ton of logic in
entries.c to get the scheduling correct. Use it.

>...

Cheers,
-g
Received on 2010-06-30 19:10:29 CEST