[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r958698 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 29 Jun 2010 10:38:14 +0200

> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: dinsdag 29 juni 2010 10:01
> To: Bert Huijben
> Cc: Subversion Dev
> Subject: Re: svn commit: r958698 - in
> /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c
>
> Bert Huijben wrote:
> > Log:
> > Allow svn_wc__db_add_directory() to attach a directory to its parent,
> to
> > allow removing another use case of entries from svn_wc_add4().
> >
> > * subversion/libsvn_wc/adm_ops.c
> > (svn_wc_add4): Move for copyfrom_url in repos_root out
> > of the entries handling. Directly remove incomplete entry from
> new
> > directory when we only need the directory for local additions.
> Use
> > svn_wc__db_op_add_directory() for directory additions.
> >
> > * subversion/libsvn_wc/wc_db.c
> > (svn_wc__db_op_add_directory): Hook directory to parent directory
> > instead of just ignoring the parent when the directories are not
> > attached. Ignoring the parent is never valid as a top level
> wcroot
> > can never be added.
>
> Hi Bert. That comment about svn_wc__db_op_add_directory() sounds like
> it would be useful to have in the function's doc string.

That is an internal detail on a bugfix and on how wc_db operates internally *now*, which will be invalid when we move to a single DB (because you don't have stubs then). The function simply doesn't work as advertized when you don't apply this rule.

        Bert
Received on 2010-06-29 10:40:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.