Re: svn commit: r958671 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

Greg Stein wrote on Mon, 28 Jun 2010 at 22:16 -0000:
> On Mon, Jun 28, 2010 at 14:59, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Greg Stein wrote on Mon, 28 Jun 2010 at 21:50 -0000:
> >> How am I supposed to review this? I can't tell what is indentation,
> >> versus actual code change.
> >>
> >
> > svn diff -x-w ?
>
> Sure, I could do that, but reviewing commit emails is much easier.

Agreed. Just saying what you could do for this revision (which is
already committed).

(last time it happened *I* forgot about the -x-w option, that's why I'm
mentioning it here now)

> No context switching. No cut/paste of revision numbers. I can actually
> reply in-line with comments/suggestions. etc.
>
> (tho I expect I'm speaking to the choir here :-P )
>
> > (on s.c.n viewvc's diffs used to ignore whitespace... doesn't seem to be
> > the case on s.a.o though)
>
> Whitespace can be important (e.g Python scripts), so keeping simple
> whitespace changes in the commit email is a Good Thing.

+1. (I'm used to being able to just pipe a commit mail to 'svn patch'.)

> I hadn't realized that s.c.n did that.
>

In its default view, yes. (it also had a 'view raw unidiff' mode)

> Cheers,
> -g
>
Received on 2010-06-28 21:24:20 CEST