[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r958583 - /subversion/trunk/subversion/tests/svn_test_main.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 28 Jun 2010 14:40:12 -0400

On Mon, Jun 28, 2010 at 10:09, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Mon Jun 28 14:09:33 2010
> New Revision: 958583
>
> URL: http://svn.apache.org/viewvc?rev=958583&view=rev
> Log:
> * subversion/tests/svn_test_main.c
>  (main): Configure the Subversion library to raise an error on assertion
>    failure, so we can catch it and report a test failure instead of
>    aborting the test run.

No.

I said the same thing to Stefan a while back when he tried to make a
similar change. Those assertions should continue to fail as they
normally do. When I'm testing, I *want* that core dump.

The testing code should use SVN_TEST_ASSERT() or
SVN_TEST_STRING_ASSERT(). These "assertions" will do the right thing,
rather than dumping core. (Stefan was using normal assertions in his
test code, which was the incorrect part)

>...

Cheers,
-g
Received on 2010-06-28 20:40:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.