[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Patch] - Fix paths on OS/2 - patch for trunk - svn-paths-trunk.diff [1/1]

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 25 Jun 2010 13:10:56 +0100

Bert Huijben wrote:
> > -----Original Message-----
> > From: Paul Smedley [mailto:pauldespam_at_despamsmedley.id.au]
> >
> > [[[
> > Fix paths & command prompts for OS/2 by re-using WIN32 #ifdef's
> >
> > * subversion/libsvn_subr/dirent_uri.c
> > * subversion/libsvn_subr/io.c
> > * subversion/libsvn_subr/prompt.c
> > * subversion/libsvn_ra_local/split_url.c
> > * subversion/libsvn_fs_fs/fs_fs.c
> > (various): Use WIN32 code for paths with drive letters and command
> > prompts
> > ]]]
>
> I applied the fs_fs part of this patch on trunk by just using our svn_io api
> in r957838, r957840.
> The io.c part is applied in r957857, with further unrelated tweaks in
> r957860 and r957862.
>
> The dirent_uri and split_url parts require further tweaks in our testsuite
> which explicitly tests for some of this behavior. (I didn't apply these).
>
> In r957893, I moved the relevant code from
> subversion/libsvn_ra_local/split_url.c into
> subversion/libsvn_subr/dirent_uri.c to make it possible to redefine url
> handling in just one place.
>
> Then r957905, cleaned up dirent_uri.c and dirent_uri-tests.c to use a single
> define to specify if dos path rules are used. I enabled this for WIN32,
> Cygwin and OS/2.
>
> I think this only leaves the prompt.c part.

Nice work, Bert! And Paul, thanks for sending your patch which prompted
this further clean-up.

- Julian
Received on 2010-06-25 14:11:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.