[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Let "svn blame" truncate long author names to keep the column width fixed to 10 characters

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 25 Jun 2010 11:19:05 +0100

Johan Corveleyn wrote:
> On Thu, Jun 24, 2010 at 1:47 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > You truncate the author name even in 'svn blame -v' --- is that per the
> > previous thread's concensus too? (Personally I lean towards not
> > truncating with -v.)
>
> Thanks for the feedback.
>
> I didn't consider that -v would have to be handled differently, but I
> see your point (verbose may imply not to drop any information for the
> sake of formatting). The previous thread didn't talk about "blame -v",
> just "blame" in general, so I thought the consensus of the thread
> applied to all blame output, whether -v or regular. But maybe that was
> not the intent.
>
> I don't really have a preference one way or the other. I never use
> "blame -v" from the command line (and it wasn't really my personal
> problem anyway, I just took it on to get some exercise in svn hacking
> ;). So I'll let you guys decide ...

In my opinion, "blame -v" is not very good for direct viewing, so I
expect it is more often filtered in some way before the user views it.
In the interest of solving the most likely scenario (viewing the
non-verbose output neatly) without making unnecessary other changes, I
vote for leaving the "blame -v" output unchanged.

Done; committed in r957874, omitting the "blame -v" part.

Thank you for the patches!
- Julian
Received on 2010-06-25 12:19:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.