[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r956941 - /subversion/trunk/subversion/libsvn_subr/io.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 22 Jun 2010 23:18:48 +0300 (Jerusalem Daylight Time)

julianfoad_at_apache.org wrote on Tue, 22 Jun 2010 at 19:18 -0000:
> @@ -3665,7 +3667,7 @@ temp_file_create(apr_file_t **new_file,
> #endif
> }
>
> -/* Wrapper for apr_file_name_get(). */
> +/* Wrapper for apr_file_name_get(), passing out a UTF8-encoded filename. */
> svn_error_t *
> svn_io_file_name_get(const char **filename,
> apr_file_t *file,

Doesn't this also belong in the public docs of this function?

[[[
Index: subversion/include/svn_io.h
===================================================================
--- subversion/include/svn_io.h (revision 956596)
+++ subversion/include/svn_io.h (working copy)
@@ -1921,7 +1921,8 @@
                           int version,
                           apr_pool_t *pool);
 
-/** Wrapper for apr_file_name_get().
+/** Wrapper for apr_file_name_get(). The encoding of @a *filename
+ * is UTF-8.
  *
  * @since New in 1.7. */
 svn_error_t *
]]]

While here, thanks for continually ensuring that we have proper docs
for our internal functions.

Daniel
Received on 2010-06-22 22:18:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.