[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: revprop changes and hooks

From: Jon Foster <Jon.Foster_at_cabot.co.uk>
Date: Tue, 22 Jun 2010 14:59:14 +0100

Hi,

Daniel Shahaf wrote:
> But I wonder if, while here, we could go further and obtain
> the "expected old property value" from the RA layer (and
> pass it to the pre-hook). (This probably means revving
> svn_ra_change_rev_prop() the same way svn_fs_change_rev_prop()
> was revved.) That will allow "svn propset k v
> --if-old-value-is=vprime" to work...

That would also fix the known race condition in svnsync.
Svnsync locks the remote repository by creating a revprop.
We really want that to be an atomic "create revprop if not
exist" operation, which would be possible with this new API.
The current implementation does a non-atomic test-then-set,
which is racy.

Kind regards,

Jon

**********************************************************************
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd.

If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.

Cabot Communications Limited
Verona House, Filwood Road, Bristol BS16 3RY, UK
+44 (0) 1179584232

Co. Registered in England number 02817269

Please contact the sender if you believe you have received this email in error.

**********************************************************************

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
Received on 2010-06-22 16:01:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.