[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG: WC-NG code crawls too high to find WC root

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Sat, 19 Jun 2010 22:30:53 -0400

C. Michael Pilato wrote:
> C. Michael Pilato wrote:
>> From time to time, I've seen evidence that our trunk code is walking up too
>> far in its parent tree as well, but every time I try to create a reliable
>> recipe, I can't. I have nothing but wc-1 working copies on my system for
>> day-to-day use. (I run subversion 1.6.x by default.) My home directory is
>> versioned, for example, as is the directory ~/tests (but nothing inside
>> ~/tests is versioned). What I've seen, though, is that if I use trunk svn
>> to do some testing, creating working copies and such inside ~/test/,
>> sometimes I get errors that indicate that the client has crawled up out of
>> that wc-ng working copy and is looking at ~/test/. Obviously, it'd be fine
>> if it crawled up that far, realized that it had gone above the WC root, and
>> just gracefully realized that it had crawled too far. But instead, it fails
>> with an error. Unfortunately, I can't recall which error is presented:
>> "working copy is too old", perhaps.

(Just to close off this thread) I fixed this bug myself in r956119 by adding
a new macro which combines the check for SVN_ERR_WC_NOT_WORKING_COPY and
SVN_ERR_WC_UPGRADE_REQUIRED, and then made use of the macro in many places
where the former of those errors was checked. Don't worry -- Subversion
still tells you if you try to operate directly on a pre-1.7 working copy
that you need to upgrade. But crawls up the parent chain now stop where
they used to (and should): at the first directory that's not a (valid)
working copy.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
Received on 2010-06-20 04:31:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.