[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: revprop changes and hooks

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 18 Jun 2010 21:17:59 +0300 (IDT)

C. Michael Pilato wrote on Fri, 18 Jun 2010 at 09:48 -0400:
> Daniel Shahaf wrote:
> > * ra_dav: I don't know about this one.
> >
> > From the neon/serf side, adding the optional "expected preexisting
> > value" should be straightforward (just another tag/attribute).
> >
> > From the mod_dav_svn side, however, the propchanges/propdeletes come
> > from db_store/db_remove (respectively), and I don't know/see how
> > mod_dav_svn could obtain the optional "expected preexisting value"
> > (even if it were present in the request).
> >
> > Could someone teach me how mod_dav_svn might be able to obtain the
> > optional "expected preexisting value"?
>
> Could it get stuffed into the dav_db structure?

You mean, to extend the dav_db structure to hold that information? If
that's possible, I suppose the only candidate for filling in that
information is db_open(), who can examine its dav_resource object. But
does the dav_resource object contain the needed information? Or do we
need the request_rec object for that?

(Disclaimer: I could be talking complete nonsense; it's my first time
inside the httpd/mod_dav code.)

> Does mod_dav open and close the DAV properties database exactly once
> per PROPPATCH?
>

Yes. (I checked dav_method_proppatch() in <main/mod_dav.c>.) Why is
this important to know?

>
Received on 2010-06-18 20:18:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.