Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

Julian Foad wrote on Thu, 17 Jun 2010 at 14:53 +0100:
> On Wed, 2010-06-16, C. Michael Pilato wrote:
> > If we decide that we need to rev this API, though, then let's do the sane
>
> (Did you mean "rev this API" or merely "change it in any way"?)
>
> > thing and teach the function to return *all* the known APR file types so we
> > don't have to revisit this API again later. We can backport a private
> > implementation of the function for the purposes of fixing the bug in 1.6.x.
>
> Yes, we might as well make svn_io_dir_walk() return all possible kinds
> of node, now that we're changing it at all.
>

Or we might say: "This returns APR_REG, APR_DIR, and may return more types
in the future; don't assume this is an exhaustive list".

> Oh, and the doc string needs updating: it explicitly says "files and
> directories".
>

Symlinks are files? In a way? :-)

(Yes, couldn't hurt to be explicit.)
Received on 2010-06-17 16:00:29 CEST