[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r954830 - in /subversion/trunk/subversion/tests/cmdline: svnadmin_tests.py svntest/actions.py svntest/main.py svntest/sandbox.py tree_conflict_tests.py

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 16 Jun 2010 14:57:45 -0500

On Wed, Jun 16, 2010 at 11:21 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> hwright_at_apache.org writes:
>
>> Author: hwright
>> Date: Tue Jun 15 11:35:36 2010
>> New Revision: 954830
>
>> -  if verbose_mode and quiet_mode:
>> -    sys.stderr.write("ERROR: 'verbose' and 'quiet' are incompatible\n")
>> -    sys.exit(1)
>> +    if not appended:
>> +      parser.error("invalid test number, range of numbers, " +
>> +                   "or function '%s'\n" % arg)
>
> In the past I could run './basic_tests.py list' now I get
>
> ../../../../src/subversion/tests/cmdline/basic_tests.py list
> Traceback (most recent call last):
>  File "../../../../src/subversion/tests/cmdline/basic_tests.py", line 2571, in <module>
>    svntest.main.run_tests(test_list)
>  File "/home/pm/sw/subversion/src/subversion/tests/cmdline/svntest/main.py", line 1439, in run_tests
>    parser.error("invalid test number, range of numbers, " +
> NameError: global name 'parser' is not defined

Using './basic_tests.py list' has been deprecated for a very long
time, replaced by './basic_tests.py --list'. My rewrite of the
options parsing removed the hack that supported the non-optioned
version of '--list'.

The error message could be a bit more friendly, thought, and that's
what I did in r955354.

-Hyrum
Received on 2010-06-16 21:58:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.