[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 16 Jun 2010 16:11:07 +0100

> * r950445, 950468
> Fix for issue #2591 "'svnadmin hotcopy' does not replicate symlinks".
> Justification:
> This fix helps server administrators who has common files symlinked
> across their repositories and take frequent backups of their repos
> using svnadmin hotcopy.
> Notes:
> r950445 fixes the issue and r950468 is a test for this issue.
> Votes:
> +1: stylesen, cmpilato

I tested this change and it works.

However, it changes the semantics of the API svn_io_dir_walk().
Strictly speaking, we should not do that in a back-port (nor even in
trunk except by revving the API).

Previously, svn_io_dir_walk() reported only files and dirs. With this
change it reports symlinks in the same way that it reports files (even
if they point to a directory).

The question is: do we regard that change as an acceptable bug fix and
allow it, or do we require the behaviour of the existing API to be left
unchanged and get the "hotcopy" behaviour change some other way?

I voted "-0" in r955255.

- Julian
Received on 2010-06-16 17:11:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.