[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Fixing blame misalignment for >1m revs - some questions

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Tue, 15 Jun 2010 16:09:11 +0200

Hi devs,

Recall a discussion on this list about a small bug in command line
"svn blame": if blame output contains a revision number larger than 6
characters (i.e. >= 1000000) the columns would not be correctly
aligned (see [1]). I promised in that thread to fix this, as my first
svn hacking exercise. However, finding some free time to do this took
me much longer than I expected/wanted ("a couple of days" has now
become "a couple of months). Sorry about that.

Anyway, moving on, I want to pick up the ball again. I have some
(newbie) questions about the proposed solution (using "end_revnum" to
determine the maximum column width for the revnum).

1) To do this, the blame_receiver callback needs to know the
end_revnum. So I need to extend svn_client_blame_receiver3_t to
include end_revnum as a parameter, right (so it can be passed to the
receiver inside svn_client_blame5 (blame.c))?

2) Since svn_client_blame_receiver3_t was introduced in 1.7 (according
to the comment), can I just change it, or do I still have to introduce
a svn_client_blame_receiver4_t for backward compat?

3) Do I add the end_revnum parameter at the end of the parameter list,
just before the *pool?


[1] http://svn.haxx.se/dev/archive-2010-04/0463.shtml


Received on 2010-06-15 16:15:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.