[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r954136 - /subversion/trunk/build/run_tests.py

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Sun, 13 Jun 2010 00:13:27 +0200

On Sat, Jun 12, 2010 at 11:52 PM, Bert Huijben <bert_at_vmoo.com> wrote:

>
>
> > -----Original Message-----
> > From: hwright_at_apache.org [mailto:hwright_at_apache.org]
> > Sent: zaterdag 12 juni 2010 22:48
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r954136 - /subversion/trunk/build/run_tests.py
> >
> > Author: hwright
> > Date: Sat Jun 12 20:48:17 2010
> > New Revision: 954136
> >
> > URL: http://svn.apache.org/viewvc?rev=954136&view=rev
> > Log:
> > * build/run_tests.py
> > (_run_test): Hopefully fix the windows tests by passing the correct
> > arguments to subprocess.call().
> >
> > Modified:
> > subversion/trunk/build/run_tests.py
> >
> > Modified: subversion/trunk/build/run_tests.py
> > URL:
> > http://svn.apache.org/viewvc/subversion/trunk/build/run_tests.py?rev=95
> > 4136&r1=954135&r2=954136&view=diff
> > ==========================================================
> > ====================
> > --- subversion/trunk/build/run_tests.py (original)
> > +++ subversion/trunk/build/run_tests.py Sat Jun 12 20:48:17 2010
> > @@ -345,7 +345,7 @@ class TestHarness:
> > if self.log:
> > os.dup2(self.log.fileno(), 1)
> > os.dup2(self.log.fileno(), 2)
> > - rv = subprocess.call(arglist)
> > + rv = subprocess.call([progname] + arglist[1:])
>
> Not sure why, but after this patch it seems that the applications only see
> [progname] and not arglist.
>
> The real problem was that spawnv asked the program to quote the strings,
> while subprocess handles the quoting for you. (And Windows can't find the
> file '"somefile.py"' ). Fixed in r954143.
>

Thanks. I was sorry to break the windows tests, but figured you'd fix them
in short order; I just didn't think it'd be *this* fast. :)

-Hyrum
Received on 2010-06-13 00:14:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.