[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixing prop_tests.py failure in Solaris

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 9 Jun 2010 12:36:31 +0200

On Wed, Jun 09, 2010 at 02:03:01PM +0530, Alexander Thomas wrote:
> On Wed, 2010-06-09 at 09:51 +0200, Stefan Sperling wrote:
> > On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote:
> > > [[[
> > > Replace existing invalid propname to make test pass in Solaris.
> > >
> > > * subversion/tests/cmdline/prop_tests.py
> > > (invalid_propnames): Changed propname to empty char.
> > > ]]]
> > >
> > >
> > > -Alexander Thomas (AT)
> >
> > > Index: subversion/tests/cmdline/prop_tests.py
> > > ===================================================================
> > > --- subversion/tests/cmdline/prop_tests.py (revision 952911)
> > > +++ subversion/tests/cmdline/prop_tests.py (working copy)
> > > @@ -1420,7 +1420,7 @@
> > > cwd = os.getcwd()
> > > os.chdir(wc_dir)
> > >
> > > - propname = chr(8)
> > > + propname = ''
> >
> > The test used to check for an unprintable ascii character (backspace).
> > With this patch, it checks for an empty string.
> > I'm not sure if this is a good thing to do.
> >
> I meant to use chr(32) and not an empty string. Subversion will treat
> propnames starting with space as invalid.
> Should I post another patch?

char(32) is ascii '2'.

I don't know the naming rules of svn off-hand. Is the test trying
to use a non-printable character on purpose? If so, we should keep
using a non-printable character.

> > In what way does chr(8) make this test fail on Solaris?
> prop commands errors with "svn: Non-ASCII character (code 8) detected,
> and unable to convert to/from UTF-8" in solaris. I tried different
> non-printable characters which resulted in same error.

That sounds like a problem with your build, or with your locale
settings.

Since ASCII is a subset of UTF-8, these errors usually show when people
try using characters that are not in ascii, and do not have and iconv
implementation linked into apr-util. I don't think this applies in your
case, but we should still check.

Do you have apr-util linked to an iconv implementation (GNU libiconv
or APR iconv)? If apr-util has no iconv, Subversion won't be able
to convert anything from/to UTF-8.

Do the utf tests in subversion/tests/libsvn_subr/utf_tests.c pass for you?
If they don't pass, then you're trying to fix the wrong problem.
If they do pass, we'll need to dig deeper and determine why the prop
test is failing for you.

It would be great if you could build with --enable-maintainer-mode and
show the error trace of the failing test. An easy way is to just post
the entire output of ./prop_tests.py --verbose invalid_propnames

Thanks,
Stefan
Received on 2010-06-09 12:37:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.