[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixing prop_tests.py failure in Solaris

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 9 Jun 2010 09:51:35 +0200

On Wed, Jun 09, 2010 at 12:55:26PM +0530, Alexander Thomas wrote:
> [[[
> Replace existing invalid propname to make test pass in Solaris.
>
> * subversion/tests/cmdline/prop_tests.py
> (invalid_propnames): Changed propname to empty char.
> ]]]
>
>
> -Alexander Thomas (AT)

> Index: subversion/tests/cmdline/prop_tests.py
> ===================================================================
> --- subversion/tests/cmdline/prop_tests.py (revision 952911)
> +++ subversion/tests/cmdline/prop_tests.py (working copy)
> @@ -1420,7 +1420,7 @@
> cwd = os.getcwd()
> os.chdir(wc_dir)
>
> - propname = chr(8)
> + propname = ''

The test used to check for an unprintable ascii character (backspace).
With this patch, it checks for an empty string.
I'm not sure if this is a good thing to do.

In what way does chr(8) make this test fail on Solaris?
Maybe we can find a better solution?

Thanks,
Stefan

> propval = 'foo'
>
> expected_stderr = (".*Attempting to delete nonexistent property "
Received on 2010-06-09 09:52:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.