[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r948525 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c libsvn_client/status.c libsvn_wc/status.c

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 3 Jun 2010 16:23:50 -0400

On Wed, May 26, 2010 at 14:32, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Wed May 26 18:32:49 2010
> New Revision: 948525
>
> URL: http://svn.apache.org/viewvc?rev=948525&view=rev
> Log:
> Remove the get_excluded support from the svn status walker that was introduced
> in r888508 to fix issues in 'svnversion'. An optimized revision walker that
> doesn't use the status walker was written later, removing the only valid user
> of get_excluded true.
>
> * subversion/include/svn_wc.h
>  (svn_wc_walk_status): Remove get_excluded argument.
>
> * subversion/libsvn_client/patch.c
>  (check_dir_empty): Update caller. This caller should have never passed
>    true for get_excluded, as this breaks deleting a directory with
>    not_present nodes.

This is an argument for creating a regression test for this situation.

>...

Cheers,
-g
Received on 2010-06-03 22:24:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.