[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: A notification framework for libsvn_repos

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 28 May 2010 14:15:13 -0500

On Fri, May 28, 2010 at 10:22 AM, Hyrum K. Wright <
hyrum_wright_at_mail.utexas.edu> wrote:

> In poking around libsvn_repos lately, I've found a somewhat neglected
> corner of the library: the notification system. Several functions return
> notifications back to the caller (typically 'svnadmin'), but they all use
> different callback types. In the case of svn_repos_load_fs2(), the output
> is generated directly inside of libsvn_repos(!), and just fed into a stream
> the caller provides.
>
> I think we can unify the notifications in libsvn_repos without too much
> difficulty by emulating the svn_wc_notify_t framework. It would give
> callers much more fine-grained control over knowing what is going on in the
> process, rather than having to parse a stream or implement 3 different
> callbacks. With the prevalence of remove-administration tools, I think this
> is a good benefit.
>
> My one concern is that this will be too much overhead for something like
> load, which creates lots of notifications. (Actually, load could probably
> just reuse the same baton, resetting values differently each time.
> Hmmm....)
>

Additional research has shown that at least one of the existing progress
functions has been added in 1.7, so we've still got some time to update it
for a more general framework. Investigating...

-Hyrum
Received on 2010-05-28 21:15:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.