[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v4] speed up svn_txdelta_apply_instructions

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 26 May 2010 16:57:18 +0100

Hi Stefan.

Just a quick note to say thanks for this, but there seems to be a
problem with this version when compiling:

  text_delta.c:709: warning: comparison between pointer and integer

and when running the test suite in a trunk head build:

  text_delta.c:693: svn_txdelta_apply_instructions: Assertion `left > 0'
failed.

- Julian

On Sat, 2010-05-22, Stefan Fuhrmann wrote:
> Hi there,
>
> this is an improved version of the patch posted here:
>
>
> http://mail-archives.apache.org/mod_mbox/subversion-dev/201005.mbox/%3C4BF5BC07.8060406@alice-dsl.de%3E
>
> It should address all the questions raised in that thread by
>
> * keeping it as close to the original as possible
> by looping over window ops instead of the target buffer
> * disabling the chunky copy optimization on non-x86/x64
> * vastly extended commentary explaining the consistency
> requirements as well as the role of the assertions.
>
> -- Stefan^2.
Received on 2010-05-26 17:57:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.