[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue 3085 mod_dav_svn and pre-revprop-change hooks

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 24 May 2010 15:54:13 -0400

> I can be sneaky and work around this. When the hook fails mod_dav_svn
> can cache the error, and then when rollback gets invoked the cached
> error can be returned even though rollback is otherwise a no-op.
> What do people think? I suppose the proper solution is to change
> mod_dav to return Subversion's error but then users would need to
> coordinate upgrades to both mod_dav_svn and mod_dav.

It probably wouldn't be either the first or the last time we've had to work
around mod_dav. +1 from me so long as the *code* documents the reason for
the unexpected behavior -- you could simply port the wonderful explanation
from this email into a code comment, even.

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-05-24 22:54:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.