[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r946495 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 19 May 2010 23:20:01 -0400

Why was this not found by the compiler?

On Wed, May 19, 2010 at 20:42, <stsp_at_apache.org> wrote:
> Author: stsp
> Date: Thu May 20 00:42:09 2010
> New Revision: 946495
>
> URL: http://svn.apache.org/viewvc?rev=946495&view=rev
> Log:
> * subversion/libsvn_wc/deprecated.c
>  (wrap_4to3_dir_opened): Accept the new SKIP_CHILDREN parameter which
>   was added to dir_opened in r946186. Just set it to FALSE if not NULL,
>   because the callbacks3 version of this callback doesn't know any better.
>
> Found by: julianfoad
>
> Modified:
>    subversion/trunk/subversion/libsvn_wc/deprecated.c
>
> Modified: subversion/trunk/subversion/libsvn_wc/deprecated.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/deprecated.c?rev=946495&r1=946494&r2=946495&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_wc/deprecated.c (original)
> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Thu May 20 00:42:09 2010
> @@ -1622,6 +1622,7 @@ wrap_4to3_dir_props_changed(const char *
>  static svn_error_t *
>  wrap_4to3_dir_opened(const char *local_dir_abspath,
>                      svn_boolean_t *tree_conflicted,
> +                     svn_boolean_t *skip_children,
>                      const char *path,
>                      svn_revnum_t rev,
>                      void *diff_baton,
> @@ -1633,6 +1634,8 @@ wrap_4to3_dir_opened(const char *local_d
>   if (local_dir_abspath)
>     adm_access = svn_wc__adm_retrieve_internal2(b->db, local_dir_abspath,
>                                                 scratch_pool);
> +  if (skip_children)
> +    *skip_children = FALSE;
>
>   return b->callbacks3->dir_opened(adm_access, tree_conflicted, path, rev,
>                                    b->baton);
>
>
>
Received on 2010-05-20 05:20:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.