[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r946475 - /subversion/trunk/tools/dev/unix-build/Makefile.svn

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 20 May 2010 02:24:26 +0200

On Wed, May 19, 2010 at 04:06:05PM -0700, Blair Zajac wrote:
> On 05/19/2010 03:58 PM, stsp_at_apache.org wrote:
> >Author: stsp
> >Date: Wed May 19 22:58:37 2010
> >New Revision: 946475
> >
> >URL: http://svn.apache.org/viewvc?rev=946475&view=rev
> >Log:
> >* tools/dev/unix-build/Makefile.svn: Fix a comment typo. Set LD_LIBRARY_PATH
> > when running tests for perl and python bindings.
> >
>
> > svn-check-swig-pl:
> >- cd $(svn_builddir)&& make check-swig-pl
> >+ cd $(svn_builddir)&& \
> >+ env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) make check-swig-pl
>
> I don't think you need the "env" here, isn't using
> LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) sufficient, since our Makefile's
> use Bourne shell by default.

It possibly is. I'm using env in a couple of other places in this
file though. I don't think it hurts.

Note that this isn't hooked up to our standard makefiles at all.
It's just a wrapper that fetches dependencies, builds svn, can
run multi-way tests and some other things. It may be worth lifting
some functionality from it into our standard Makefile eventually.
Basically I use it to build my own development builds, that's all.

Thanks,
Stefan
Received on 2010-05-20 02:25:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.