[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r945034 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit_util.c libsvn_wc/node.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 19 May 2010 16:14:50 +0100

Greg Stein <gstein_at_gmail.com> writes:

> On Mon, May 17, 2010 at 05:03, <philip_at_apache.org> wrote:
>> Author: philip
>> Date: Mon May 17 09:03:36 2010
>> New Revision: 945034
>>
>> URL: http://svn.apache.org/viewvc?rev=945034&view=rev
>> Log:
>> * subversion/include/private/svn_wc_private.h
>>  (svn_wc__db_temp_get_keep_local): Renamed to ...
>>  (svn_wc__temp_get_keep_local): ... this.
>>
>> * subversion/libsvn_wc/node.c
>>  (svn_wc__db_temp_get_keep_local): Renamed to ...
>>  (svn_wc__temp_get_keep_local): ... this.
>
> Okay. This is better. But really... why was this ever named something
> *besides* svn_wc__node_foo. ? It lives in node.c just like all the
> other node functions. All node functions are temporary, by definition.
> I just don't understand the rationale for why it ever used a different
> namespace to start with.
>
> ??
>
>>...
>
> (not asking for change; just insight)

I simply got confused by our naming conventions.

-- 
Philip
Received on 2010-05-19 17:15:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.