On Wed, May 19, 2010 at 05:37, Bert Huijben <bert_at_qqmail.nl> wrote:
>> + abs_path = svn_uri_join(parent_url + strlen(wb->repos_root),
>> + svn_dirent_basename(local_abspath,
>> + pool);
> And this has the same issues with encoding. (And I don't know what you are
> calculating here. It doesn't look like an absolute dirent. Please use a
> different variable name).
That is the 'abs_path' grammar token from the URI specification.
>> @@ -2585,6 +2685,14 @@ svn_wc_dup_status3(const svn_wc_status3_t *orig_st
>> = apr_pstrdup(pool, orig_stat->changelist);
>> + if (orig_stat->repos_root_url)
>> + new_stat->repos_root_url
>> + = apr_pstrdup(pool, orig_stat->repos_root_url);
>> + if (orig_stat->repos_relpath)
>> + new_stat->repos_relpath
>> + = apr_pstrdup(pool, orig_stat->repos_relpath);
> Do you have to duplicate these values, or is the lifetime of these orig_stat
> values long enough?
> (I think you can just set the value from the parent, but I didn't check)
This is in dup() ... you *have* to duplicate these values. ??
Received on 2010-05-19 14:40:35 CEST