[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r945280 - in /subversion/trunk: build.conf subversion/libsvn_ra_serf/commit.c subversion/mod_dav_svn/dav_svn.h subversion/mod_dav_svn/posts/ subversion/mod_dav_svn/posts/create-transaction.c subversion/mod_dav_svn/repos.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 17 May 2010 14:56:05 -0400

More XML crap? Yuck, ugh, and bleagh.

On Mon, May 17, 2010 at 14:09, <cmpilato_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/mod_dav_svn/posts/create-transaction.c Mon May 17 18:09:28 2010
>...
> +/* Respond to a S:dated-rev-report request. */
> +int
> +dav_svn__create_transaction_post(const dav_resource *resource,
> +                                 const apr_xml_doc *doc,
> +                                 ap_filter_t *output)
> +{
> +  request_rec *r = resource->info->r;
> +  apr_bucket_brigade *bb;
> +  apr_status_t apr_err;
> +  dav_error *derr = NULL;
> +  const char *txn_name;
> +
> +  /* Create a Subversion repository transaction based on HEAD, and
> +     return the new transaction's name in a custom "201 Created"
> +     response header.  */
> +  derr = dav_svn__create_txn(resource->info->repos, &txn_name, resource->pool);
> +  if (derr)
> +    return dav_svn__error_response_tag(r, derr);

This doesn't match the "int" return type you've defined, and it
results in build errors (see the buildbots).

>...
> +            {
> +              if (strcmp(doc->root->name, "create-transaction") == 0)
> +                {
> +                  return dav_svn__create_transaction_post(resource, doc,
> +                                                          r->output_filters);

And this seems to want an int.

>...

Can I say again that I hate XML, and am very much -0.5 on using it in
our protocol like this? These bodies have nothing to conform to, so
there is no reason to use XML. If you're doing it for *expedience*
rather than *propriety*, then I'd suggest taking short cuts now could
hurt us in the long term. XML means we need to deal with escaping as
we move forward. It is overly wordy. Hard to write parsing code. etc
etc.

-g
Received on 2010-05-17 20:56:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.