[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r944184 - /subversion/trunk/subversion/libsvn_wc/deprecated.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 14 May 2010 07:14:22 -0400

On Fri, May 14, 2010 at 06:05, <philip_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri May 14 10:05:18 2010
>...
> +svn_error_t *
> +svn_wc__entry_versioned_internal(const svn_wc_entry_t **entry,
> +                                 const char *path,
> +                                 svn_wc_adm_access_t *adm_access,
> +                                 svn_boolean_t show_hidden,
> +                                 const char *caller_filename,
> +                                 int caller_lineno,
> +                                 apr_pool_t *pool)
> +{
> +  svn_wc_context_t *wc_ctx;
> +  const char *local_abspath;
> +
> +  SVN_ERR(svn_wc__context_create_with_db(&wc_ctx, NULL,
> +                                         svn_wc__adm_get_db(adm_access),
> +                                         pool));
> +
> +  SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
> +
> +  SVN_ERR(svn_wc__get_entry_versioned(entry, wc_ctx, local_abspath,
> +                                      svn_node_unknown, show_hidden,
> +                                      FALSE, /* NEED_PARENT_STUB */
> +                                      pool, pool));

You should be able to call something else which does not require
WC_CTX, but only DB. Thus, you can avoid a context creation.

In fact, svn_wc__get_entry_versioned() and svn_wc__maybe_get_entry()
should be *removed* from svn_wc_private.h. The current libsvn_client
does not use/call them. Not sure what else in libsvn_wc may use them,
but there could be further ripple-based removal of functions here.

>...

Cheers,
-g
Received on 2010-05-14 13:14:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.