[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r942170 - in /subversion/trunk/subversion/libsvn_wc: props.c props.h status.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 11 May 2010 18:44:33 -0400

On Tue, May 11, 2010 at 14:17, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, May 11, 2010 at 12:39, Philip Martin <philip.martin_at_wandisco.com> wrote:
>...
>> It appears that the main testsuite doesn't check status on missing,
>> deleted directories.  942170 is when a simple 'svn st' started
>> failing, 'svn st -u' has been failing for much longer.  There is some

The key piece was an svn_wc__adm_missing() check before recursing on a
subdirectory. I removed that in r37361 a year ago, and put an
svn_wc__get_entry() call in its place. That would have error'd if it
could not retrieve the "real" data. (tho the error check was wrong...
no biggy)

Last August, r38991 replaced all the entry logic with some other wc-ng
gunk, and the check was lost entirely.

So today, the crawler attempts to recurse "into" an obstructing file. Whoops.

This should be a pretty simple fix...

Cheers,
-g
Received on 2010-05-12 00:45:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.