Re: [PATCH] contrib/client-side/asvn: only check files, that are part of the subversion repository

Am 06.05.2010 16:06, schrieb Stefan Sperling:
> On Thu, May 06, 2010 at 03:16:38PM +0200, Jörg Steffens wrote:
>> [[[
>> reduces error messages by checking svn return code
>>
>> * contrib/client-side/asvn
>> (recordpermissions): skip files where "svn propget" returns an error.
>> It is assumed that these files do not belong to the svn repository
>>
>> patch by joerg.steffens < at > dass-it.de
>> ]]]

> 'if [ x ]; then' is not consistent with the rest of the file.
> Usually 'then' is on a line of its own, like this:
>
> if [ x ]
> then
>
>> + # $file is not handled by svn, skipping
>
> Let's zap the above comment,
>
>> + echo "skipping property $FILE_PROP for $dir/$file"
>
> and change this messsage to:
>
> $dir/$file has no $FILE_PROP property or is unversioned; skipping

okay. Here it is.