[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: patch API review

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 04 May 2010 21:07:32 +0200

On 04.05.2010 11:46, Hyrum K. Wright wrote:
> On Wed, Apr 28, 2010 at 9:20 PM, Hyrum K. Wright<
> hyrum_wright_at_mail.utexas.edu> wrote:
>
>>
>>
>> On Wed, Apr 28, 2010 at 1:43 PM, Stefan Sperling<stsp_at_elego.de> wrote:
>>
>>> ...
>>>
>>> Also, I know that the API uses
>>>> notifications, but it might also be useful to return the _tempfile
>>>> parameters through a callback mechanism, rather than as (arbitrarily
>>> large)
>>>> hashes.
>>>
>>> That would work as well, yes. Might look nicer than having the output
>>> parameters at the front.
>>>
>>
>> I'll play around with this idea.
>>
>
> r940786 changes the API to use a patch callback function. Review welcome.

Looks good to me.
Haven't tested it though. But the API is usable from an UI client just fine.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2010-05-04 21:08:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.