[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature idea: user-configurable post-commit notifications

From: Neels J Hofmeyr <neels_at_elego.de>
Date: Wed, 28 Apr 2010 23:58:30 +0200

Bolstridge, Andrew wrote:
>> -----Original Message-----
>> From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
>> Sent: Mon 26/04/2010 19:27
>> To: Bolstridge, Andrew
>> Cc: dev_at_subversion.apache.org
>> Subject: RE: Feature idea: user-configurable post-commit notifications
>>
>> Bolstridge, Andrew wrote on Fri, 23 Apr 2010 at 13:52 +0100:
>>> So imagine if I (as a server admin, of course) could configure a new
>>> command ("svn review" or "svn special-cmd review") that uses the
>>> same mechanism as pre-commit, and calls the server hook
>>> "special-review.pl". That's 3 data items in server and client
>>> configuration - ('review', 'pre-commit', 'special-review.pl').
>
>> Just to clarify: I assume you intend that script to be run on the server
>> (using data provided by the client)?
>
> Yes, all on the server - exactly like the existing infrastructure.
> I'm not suggesting any of this be run on the client.

Re not firing a hook event with every commit: you could parse the log
message and make it so that your mechanism is only or not triggered when a
certain word or phrase is found. For a wild example, write the hook so that
it does not trigger a publish to your web if the commit's log message
contains the string "(PRELIM)". We use that in a hook script that forbids
commits that replace nodes -- because some users often do that by accident,
fragmenting history -- so if a user really knows the deal, she can write
ALLOW REPLACES anywhere in the commit message and is not bothered by the
hook anymore.

~Neels

Received on 2010-04-28 23:59:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.