[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Error with transform_sql.sh rule

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 28 Apr 2010 10:51:28 -0500

On Wed, Apr 28, 2010 at 10:35 AM, Peter Samuelson <peter_at_p12n.org> wrote:

>
> [Hyrum K. Wright]
> > Yes, this is a bug in the build / distribution process. In 1.7 and
> beyond,
> > we pretransform the sql files, since they aren't platform-dependent, but
> > those bits have yet to be backported to 1.6.x.
>
> I'd rather see us go in the opposite direction: "output is not
> platform-dependent" is not, IMO, a sufficient reason to ship "compiled"
> code in source tarballs. A better reason would be: requires tools that
> end-users shouldn't be required to install. - Like autoconf, or Python
> 2.6. When a compile / transform process does not add any build-time
> requirements, it should be done as part of the regular build.
>

On trunk, the transform script is Python, not shell. IIRC, we don't require
end users to have Python installed, so pretransforming is the most prudent
step in this case. Additionally, we have precedent in doing so: see the
swig bindings.

> Partly this is for transparency: the less "non-source" the downstream
> users have to trust our Release Manager to generate correctly from the
> same source that is shipped, the better. (Of course, an automated
> release rolling process helps a lot with this.)
>

Understood, but these bits feel like they can reasonably be done a priori.

-Hyrum
Received on 2010-04-28 17:52:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.