count-progress.py is reporting 143 uses of svn_wc__node_* in my
working copy. A quick breakdown of these calls results in:
We are 14 entry_t uses away from "done" in libsvn_client. That means
the above calls are pretty close to the end-result.
The get_kind is quite believable, and should probably move to our
public API. Seems quite reasonable, along with Neels' changes to
create better consistency in its outputs.
The get_url concerns me a bit, since most states of a node don't
actually have a URL. They may have an *intended* URL after a commit.
I'm somewhat worried those get_url calls are mis-using or do not
properly understand the "this node doesn't have a URL" concept.
get_repos_info kind of falls into this area, too.
The walk_children is pretty obvious, and I definitely think we should
have such an API in our public header. In particular, provide that API
to users rather than specialized walk/editor mechanisms, and let
callers request the specific information they need.
Received on 2010-04-27 13:24:05 CEST