[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Saving a few cycles, part 1/2

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 26 Apr 2010 11:22:31 +0100

On Sun, 2010-04-25, Stefan Fuhrmann wrote:
> In this patch, I eliminated calls to memcpy for small
> copies as they are particularly expensive in the MS CRT.

If we do decide it is worth avoiding calls to 'memcpy' for small sizes,
please don't put the expanded code in-line at the points of use, because
that obscures the functional purpose of the code. Instead, put the
optimised version in a suitably named local function ("fast_memcpy"?) so
that the main function remains easy to read.

- Julian

> [[[
> Eliminate memcpy from critical paths during reading
> data from the repository.
[...]
Received on 2010-04-26 12:23:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.