[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r937010 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/diff.c libsvn_wc/copy.c libsvn_wc/node.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 22 Apr 2010 22:13:10 -0400

Greg Stein wrote:
> Yes, you hit the nail on the head. I had a similar concern, but wasn't
> sure whether to bring it up.
>
> Specifically: in the particular case that *you* created the function
> for, the copyfrom-fetching would most likely *never* be invoked.
> node_get_url() should return a URL in almost every situation. In fact,
> I started looking at get_url to delineate exactly *which* situations
> it would not return a URL (that change is pending, but I'll quick
> finish that and commit it for demonstration).
>
> But for other cases where you may have entry->copyfrom_*, then yes...
> Philip's change is not going to be usable.
>
> I'll leave it for you to steer what kinds of query functions you need,
> and I'll get this mod to node_get_url checked in.

I agree, it's probably okay in this case. But I think the docstring for
svn_wc__node_get_copyfrom_info() needs to be updated to make its behavior clear.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-04-23 04:13:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.