[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature idea: user-configurable post-commit notifications

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 22 Apr 2010 18:56:47 -0400

Write a hook script to do exactly that, and make it part of the
standard release.

In some future release, after that script and its features stabilize,
*then* we can consider placing into into the core code.

I fear the security aspects of something like you talk about: anybody
with commit access getting the server to issue a POST request to any
arbitrary URL *reachable* by the server? Oh ho ho... I can't even
begin to describe how many alarms that would trip with security
conscious administrators.


On Thu, Apr 22, 2010 at 18:06, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> With the increased integration of build tools and other notification systems
> which desire knowledge of commit activity, it would be useful to provide an
> easier mechanism of installing post-commit notification, without having to
> use the hook infrastructure.  Imagine a user being able to set up commit
> mails, CIA notifications, and buildbot notifications *without* having to
> have access to the repository.  To that end, I propose the following.
> Simply a versioned property, which, when encountered during the course of a
> commit, causes the server to emit a notification.  This property would be a
> list of URLs, to which the repository would send a specially formatted POST
> with the information about the commit.  (The idea being that a committer to
> the project could set up this property, as well as the server which receives
> these notifications, all without the intervention of the repository
> administrator.)  As part of the bubble up, the repo would queue these URLs,
> and then POST to them during the post-commit phase of the commit.
> Thoughts?
> (Hat tip goes to Kohsuke Kawaguchi of Hudson for the idea.)
> -Hyrum
Received on 2010-04-23 00:57:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.