[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WC-NG: Commit with new pristine store and SHA-1 checksums

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 21 Apr 2010 05:46:28 -0400

On Wed, Apr 21, 2010 at 05:43, Greg Stein <gstein_at_gmail.com> wrote:
> On Wed, Apr 21, 2010 at 05:09, Philip Martin <philip.martin_at_wandisco.com> wrote:
>> Julian Foad <julian.foad_at_wandisco.com> writes:
>>
>>> COMPATIBILITY
>>> =============
>>>
>>> We need to keep the old WC interface working:
>>>
>>>   svn_wc_transmit_text_deltas2(&tempfile, &md5_digest, ...)
>>>   svn_wc_queue_committed2(queue, path, ..., md5_checksum)
>>>   svn_wc_process_committed_queue(queue, ...)
>>>
>>> How?  I can't see a way to communicate the SHA-1 checksum to
>>> svn_wc_process_committed_queue() via the queue, but I can think of the
>>> following ways.
>>
>> There is an access baton in the old interface, it's opaque and can be
>> made to store anything.  It could contain a hash of filename=>SHA-1.
>
> Presumably, transmit_text_deltas2 is a wrapper around deltas3. Thus,
> deltas2 has the SHA1 value from that inner call.
>
> Putting something into *TEMPFILE is optional, so we can skip that. The

Oop. Not optional. But we can arrange for a TEMPFILE. Or maybe refer
to the in-pristine-store file.

>...
Received on 2010-04-21 11:47:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.