[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r935579 - /subversion/trunk/subversion/libsvn_client/commit.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 19 Apr 2010 10:10:12 -0400

On Mon, Apr 19, 2010 at 10:03, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Mon Apr 19 14:03:49 2010
> New Revision: 935579
>
> URL: http://svn.apache.org/viewvc?rev=935579&view=rev
> Log:
> Tiny cosmetic tweak.
>
> * subversion/libsvn_client/commit.c
>  (post_process_commit_item): Eliminate a misleadingly named local variable.

The best way to clarify what is happening is to remove the use of
svn_iter_apr_array().

Consider: that "utility" function requires you to set up a callback
function. That callback is going to consume more lines of code in the
signature, and in the baton declaration, than a simple "for (i = 0; i
< ary->nelts; ++i)" line. One line. Or maybe +3 more to
create/clear/destroy an iterpool.

Also, locating the core of the loop where you're actually trying to
accomplish the work will result in more clarity.

I said this the other day: svn_iter_* are bastard functions and should
be eliminated from our code. They only serve to reduce code clarity.

Cheers,
-g
Received on 2010-04-19 16:10:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.