[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: Thinko in libsvn_client/merge.c?

From: Roderich Schupp <roderich.schupp_at_googlemail.com>
Date: Sun, 18 Apr 2010 18:57:53 +0200

On Thu, Apr 15, 2010 at 2:25 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Roderich Schupp wrote:
>> On Tue, Apr 13, 2010 at 4:37 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Cool.  I'll watch for your followup posts, and be glad to try to answer any
> questions you might have about the code.

OK, here's my patch for merge_reintegrate_locked.
Passes all regression tests (over local and HTTP transport).
So if we try to

svn merge --reintegrate SOME-URL ANOTHER-WC

where ANOTHER-WC is from a different repository than SOME-URL
if would previously fail with

svn: URL 'SOME-URL' is not a child of repository root URL 'ANOTHER-URL'

(where ANOTHER-URL is the URL of the repos root of ANOTHER-WC)
and now it fails with the much clearer

svn: 'SOME-URL' must be from the same repository as 'ANOTHER-WC'

However, that doesn't address the fact that this is probably another case
where a session is indiscriminantly opened at the repository root
(the root cause of issue 3242). So perhaps a "fixme" comment
should be added as well.

Fix check in "merge --reintegrate" whether merge source and
working copy target belong to the same repository.

* subversion/libsvn_client/merge.c
  (merge_reintegrate_locked) Correctly compute the repos root URL
   for the merge source.

Cheers, Roderich

Received on 2010-04-18 18:58:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.