[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r934008 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 14 Apr 2010 17:59:00 +0100

Greg Stein <gstein_at_gmail.com> writes:

>> +    SVN_ERR(svn_sqlite__open(&dst_db, dst_path, svn_sqlite__mode_rwcreate,
>> +                             NULL, 0, NULL, scratch_pool, scratch_pool));
>> +    backup = sqlite3_backup_init(dst_db->db3, "main", src_db->db3, "main");
>> +    if (!backup)
>> +      return SVN_NO_ERROR;
>
> Shouldn't the databases be closed? If not, then why not? (ie. add a comment)

Oops! I should be returning an error as well. That was supposed to
be temporary to try it out.

-- 
Philip
Received on 2010-04-14 18:59:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.