[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r933767 - in /subversion/branches/svn-patch-improvements/subversion: libsvn_client/patch.c tests/cmdline/patch_tests.py

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 14 Apr 2010 17:39:25 +0200

On Wed, Apr 14, 2010 at 03:48:49PM +0100, Julian Foad wrote:
> On Tue, 2010-04-13, stsp_at_apache.org wrote:
> > (push_if_unique): New helper function, needed because we do not use
> > a hash table anymore to ensure path uniqueness.
>
> Why not use a hash table? It looks like doing so would have good
> effects - avoiding the need for push_if_unique() and the two sub-loops
> in check_dir_empty().

I've tried various approaches including hash tables.
I found the current way of doing it easy to write and follow.

But I'm open to patches making it use hash tables instead,
if they help reduce the size of code related to deleting empty
directories.

Stefan
Received on 2010-04-14 17:39:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.