Re: svn commit: r933938 - in /subversion/trunk: build.conf subversion/include/private/svn_sqlite.h subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_subr/sqlite.c subversion/libsvn_subr/sqlite.sql

I've got a patch coming up...

On Wed, Apr 14, 2010 at 10:26, Philip Martin <philip.martin_at_wandisco.com> wrote:
> "Bert Huijben" <bert_at_qqmail.nl> writes:
>
>>> --- subversion/trunk/subversion/libsvn_subr/sqlite.c (original)
>>> +++ subversion/trunk/subversion/libsvn_subr/sqlite.c Wed Apr 14 13:05:56
>>> 2010
>>> @@ -28,6 +28,7 @@
>>>  #include "svn_io.h"
>>>  #include "svn_dirent_uri.h"
>>>  #include "svn_checksum.h"
>>> +#include "sqlite.h"
>>
>> Why did you add this include?
>>
>> A normal sqlite amalgamation has only sqlite3.c, sqlite3.h and sqlite3ext.h. This adds a dependency to another sqlite distribution format.
>
> It's the Subversion specific file generated from sqlite.sql.  Perhaps
> I should use a different name?
>
> --
> Philip
>
Received on 2010-04-14 16:27:47 CEST