[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: 1.6.10 up for testing/signing

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Tue, 13 Apr 2010 10:30:08 -0700

If you have a moment, please add my +1. Thanks.

Sent from my Windows Mobile® phone.

-----Original Message-----
From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Sent: Monday, April 12, 2010 4:51 AM
To: Joe Swatosh <joe.swatosh_at_gmail.com>
Cc: C. Michael Pilato <cmpilato_at_collab.net>; Subversion Development <dev_at_subversion.apache.org>
Subject: Re: 1.6.10 up for testing/signing

On Sun, Apr 11, 2010 at 8:27 PM, Joe Swatosh <joe.swatosh_at_gmail.com> wrote:

> Mike and Hyrum,
>
> On Mon, Apr 5, 2010 at 8:11 AM, C. Michael Pilato <cmpilato_at_collab.net>
> wrote:
> > Hyrum K. Wright wrote:
> >>> Thanks for the reminder. Merging the changed suggested here (r876245)
> does
> >>> indeed fix the test failure for me.
> >>
> >> Joe,
> >> I'm happy to +0 this patch, since it fixes the failure for me. I've no
> idea
> >> what it's doing under the hood, though, so I'd feel more comfortable if
> you
> >> were able to +1 it.
> >
> > Joe's changes are solid -- he's essentially just changed the Ruby wrapper
> > around txdelta transmission to ignore the digest. (It passes NULL to the
> > underlying C function so digest calculation never occurs.) And then he,
> of
> > course, no longer returns the uncalculated digest to callers.
> >
> > My only concern here is that it's a change to the Ruby API over what's
> > attempted in 1.6.x. If we're okay with that, you have my +1 to his fix
Received on 2010-04-13 19:30:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.