[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Follow-up to r932571 - missed one caller was: Re: svn commit: r932571 - in /subversion/trunk/subversion: include/ include/private/ libsvn_client/ libsvn_wc/ svn/

From: Daniel Näslund <daniel_at_longitudo.com>
Date: Mon, 12 Apr 2010 21:49:51 +0200

On Mon, Apr 12, 2010 at 08:58:49AM -0400, Greg Stein wrote:
> On Fri, Apr 9, 2010 at 16:16, Greg Stein <gstein_at_gmail.com> wrote:
> > On Fri, Apr 9, 2010 at 16:07,  <dannas_at_apache.org> wrote:
> >>...
> >>...
> >> +++ subversion/trunk/subversion/libsvn_wc/deprecated.c Fri Apr  9 20:07:51 2010
> >>...
> >> @@ -2515,13 +2551,15 @@ svn_wc_status2(svn_wc_status2_t **status
> >>  {
> >>   const char *local_abspath;
> >>   svn_wc_context_t *wc_ctx;
> >> +  svn_wc_status3_t *stat3;
> >>
> >>   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
> >>   SVN_ERR(svn_wc__context_create_with_db(&wc_ctx, NULL /* config */,
> >>                                          svn_wc__adm_get_db(adm_access),
> >>                                          pool));
> >>
> >> -  SVN_ERR(svn_wc_status3(status, wc_ctx, local_abspath, pool, pool));
> >> +  SVN_ERR(svn_wc_status3(&stat3, wc_ctx, local_abspath, pool, pool));
> >> +  *status = (svn_wc_status2_t *) stat3;
> >
> > Another funky cast. Make sure this gets handled with your new
> > converter function.
>
> Told ya that you'd miss this if you didn't leave yourself a reminder marker...

I have no excuses. I didn't look enough. Now, I have grepped
libsvn_{wc,client} for other uses of svn_wc_status2 and every else looks
in order.

[[[
Follow-up to r923571. Update one caller I missed in the previous
commit.

* subversion/libsvn_wc/deprecated.c
  (svn_wc_status2): Use svn_wc__status2_from_3().

Suggested by: gstein
]]]

Received on 2010-04-12 21:50:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.