[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: misaligned blame output if repo has >1m revisions

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 9 Apr 2010 22:08:21 +0100

On Fri, Apr 09, 2010 at 10:17:12PM +0200, Johan Corveleyn wrote:
> Hi devs,
>
> Just a heads up, not really important, but I came across this in
> blame_cmd.c (inside print_line_info):
>
> [[[
> const char *rev_str = SVN_IS_VALID_REVNUM(revision)
> ? apr_psprintf(pool, "%6ld", revision)
> : " -";
>
> ]]]
>
> Which means that users of a repo with over 1 million revisions will
> see misaligned blame output ...
>
> So I guess this is coming up for you guys when s.a.o reaches the 1
> million mark :-).

Nice buglet. I suppose we could simply add 2 or 3 spaces of indentation
until people run into even higher revisions in real life? :)

Stefan
Received on 2010-04-09 23:09:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.