[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: misaligned blame output if repo has >1m revisions

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 9 Apr 2010 21:37:57 +0100

On Fri, Apr 9, 2010 at 9:17 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:

> Hi devs,
>
> Just a heads up, not really important, but I came across this in
> blame_cmd.c (inside print_line_info):
>
> [[[
> const char *rev_str = SVN_IS_VALID_REVNUM(revision)
> ? apr_psprintf(pool, "%6ld", revision)
> : " -";
>
> ]]]
>
> Which means that users of a repo with over 1 million revisions will
> see misaligned blame output ...
>
> So I guess this is coming up for you guys when s.a.o reaches the 1
> million mark :-).
>

Heh. We also have a similar problem when committer names are longer than a
given threshold. I've thought about hacking a solution into the client, but
have never really gotten around to it. Do you want to write a patch?

-Hyrum
Received on 2010-04-09 22:38:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.